PR Summary

• Introduction of New Model References
  Imported Actionlog and LicenseSeat models into the Helper.php file to allow for advanced functionality.

• Addition of New Method
  Created a new method unReassignableCount($license) in Helper.php that tallies up the number of licenses that can't be reassigned.

• Revised LicenseCheckinController:

  • Altered the license check-in control, removing the need to check if a license is reassignable before checking-in.
  • Enhanced the note-keeping for licenses that can't be reassigned, allowing for more accurate record-keeping during the check-in process.
  • Changed how events are initiated to consider the revised notes.

• Upgraded LicensesController:

  • Refactored computation of checkedout_seats_count to consider licenses that can't be reassigned.
  • Following this, unreassignable_seats_count is sent for viewing.

• Transformation of LicenseSeatsTransformer:

  • Incorporated a new method unReassignable($seat) to verify if a seat is non-reassignable.
  • Altered the transformation output to feature a 'disabled' field.

• Modification of LicensesTransformer:

  • Tweaked the computation of free_seats_count to deduct the count of unReassignable licenses.

• Revision of License Model:

  • Altered remaincount() to subtract unreassignable licenses, providing a more accurate count of available licenses.

• Upgraded Blade Templates:

  • Optimized the licenses' view to display available license count subject to unreassignable seats.
  • Updated the interaction with the check-in button when a seat is disabled as depicted in bootstrap-table.

• Language Files Update:

  • Enhanced clarity by updating the message for non-reassignable licenses to 'Seat has been used' instead.

disabled button color has been fixed 👍

looking into failing tests

Not sure I love the field dead for this.

(Also, tests are failing)

Not sure I love the field dead for this.

😆 @Godmartinz and I were going back and forth on how best to communicate what the column represents.

@marcusmoore - unassignable would probably work fine, but I'd probably return a true or false if it's meant to be boolean. Or reverse the logic and use reassignable.

@snipe we (me really) were trying to avoid confusion around a license seat having assigned_to and unassignable (or a similar word) both be populated at the same time. That really threw me off and I wanted to find another word to signify "this seat might be checked out now but it cannot be checked out again in the future".

Maybe other devs won't find that as confusing as I did.

@marcusmoore reassignable_seat perhaps?

@snipe that would be a lot clearer for me. Though I would go with reassignable so we don't have a redundant word in there $licenseSeat-> reassignable_seat // @Godmartinz